New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MathJax CDN link. #2714
Update MathJax CDN link. #2714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it latest
. Using a specific version puts a huge burden on us.
There's no latest on the new CDN. |
Sphinx updated to 2.7.0 as well: sphinx-doc/sphinx@78148e9 -- there's no latest any more. Either you update to 2.7.0, or it just stops working for everyone in two weeks. |
It won't (or at least, shouldn't) stop because of the redirect. But yes, it would be good to get this fixed ASAP. @Kwpolska: how about injecting the MathJax version into the templates as a variable? (Maybe via global context?) Then at least there's only one place to update, not four. The big downside would be that everything rebuilds at the next update. I also noticed that we have the same problem with KaTeX. There, version 0.6.0 is hardcoded in the templates (while the latest version is 0.7.1). |
Putting it in Also, @Anteru: if you have a patch ready, just send a PR — otherwise, discussion might split between the two (I had to look for the announcement link in the other issue) |
Sure, I just did this because the CONTRIBUTING.rst says "First, make sure there's an open issue", then create the branch and make a pull request. I wasn't sure if it's ok to just do a PR without the issue. |
It’s okay, I’ve just reworded that section (commit a953fbb) |
Description
This fixes #2713 by updating the MathJax links to cdnjs and fixing it to version 2.7.0 (instead of latest).