Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perl5: 5.22.2 -> 5.22.3 #24832

Closed
wants to merge 2 commits into from
Closed

perl5: 5.22.2 -> 5.22.3 #24832

wants to merge 2 commits into from

Conversation

plumps
Copy link
Contributor

@plumps plumps commented Apr 11, 2017

Motivation for this change

Fix CVEs and introduce 5.24

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title Update perl5 perl5: 5.22.2 -> 5.22.3 Apr 13, 2017
@Mic92
Copy link
Member

Mic92 commented Apr 17, 2017 •
edited

Pushed to staging in d6b42b4 and f78c032 (with correct commit messages)

@vcunat should I push the perl: 5.22.2 -> 5.22.3 directly to release-17.03?

vcunat pushed a commit that referenced this pull request Apr 18, 2017
@plumps @vcunat
perl: 5.22.2 -> 5.22.3 (#24832)
4861ab9 
(cherry picked from commit d6b42b4)
@vcunat
Copy link
Member

vcunat commented Apr 18, 2017

I'm not sure about CVE, but I picked it directly. (My understanding is that for stable branches we use staging versions only during ZHF progress.)

@vcunat vcunat closed this Apr 18, 2017
@vcunat
Copy link
Member

vcunat commented Apr 19, 2017 •
edited

The new perl won't configure on darwin as it is, causing a mass failure. Any ideas? http://hydra.nixos.org/build/51761485

EDIT: version-detection seems dangerous, as we intend to support multiple Mac OS versions by a single set of binaries.

@FRidh FRidh mentioned this pull request Apr 21, 2017
Closed
@LnL7
Copy link
Member

LnL7 commented Apr 21, 2017

@vcunat This is what I suggested for erlang #21775 (comment), I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: mass-rebuild 1.severity: security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@plumps @Mic92 @vcunat @LnL7