Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

albert: 0.10.0 -> 0.10.2 #24630

Merged
merged 1 commit into from Apr 5, 2017
Merged

albert: 0.10.0 -> 0.10.2 #24630

merged 1 commit into from Apr 5, 2017

Conversation

PierreR
Copy link
Contributor

@PierreR PierreR commented Apr 4, 2017

Motivation for this change

Update albert

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@PierreR, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ericsagnes and @romildo to be potential reviewers.

@PierreR
Copy link
Contributor Author

PierreR commented Apr 4, 2017

As a note I cannot build 0.10.3.

It fails with

[ 29%] Linking CXX executable ../../bin/albert
/nix/store/k8c23rwbrril65rmm7z1036h2makk012-binutils-2.28/bin/ld: warning: libglobalshortcut.so, needed by ../../lib/libalbertcore.so, not found (try using -rpath or -rpath-link)
/nix/store/k8c23rwbrril65rmm7z1036h2makk012-binutils-2.28/bin/ld: warning: libxdg.so, needed by ../../lib/libalbertcore.so, not found (try using -rpath or -rpath-link)
../../lib/libalbertcore.so: undefined reference to `HotkeyManager::unregisterHotkey(int)'
../../lib/libalbertcore.so: undefined reference to `HotkeyManager::hotKeyPressed()'
../../lib/libalbertcore.so: undefined reference to `HotkeyManager::HotkeyManager(QObject*)'
../../lib/libalbertcore.so: undefined reference to `HotkeyManager::registerHotkey(QString const&)'
../../lib/libalbertcore.so: undefined reference to `HotkeyManager::staticMetaObject'
../../lib/libalbertcore.so: undefined reference to `HotkeyManager::~HotkeyManager()'
../../lib/libalbertcore.so: undefined reference to `XdgIconLookup::iconPath(QString, QString)'
../../lib/libalbertcore.so: undefined reference to `HotkeyManager::registerHotkey(int)'
collect2: error: ld returned 1 exit status
make[2]: *** [src/application/CMakeFiles/albert.dir/build.make:96: bin/albert] Error 1
make[1]: *** [CMakeFiles/Makefile2:86: src/application/CMakeFiles/albert.dir/all] Error 2
make: *** [Makefile:128: all] Error 2
builder for ‘/nix/store/b799hmjxmf7gza155fjdn20rna3h7bcy-albert-0.10.3.drv’ failed with exit code 2

I know nothing about qt deps, have attempted to fix it but with no luck.

rasendubi
rasendubi approved these changes Apr 5, 2017
View reviewed changes
Copy link
Member

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed nox-review on NixOS with sandboxing enabled.

@rasendubi rasendubi merged commit 8716698 into NixOS:master Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasendubi rasendubi rasendubi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PierreR @mention-bot @rasendubi