New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqlint: init at 0.1.4 #24631
sqlint: init at 0.1.4 #24631
Conversation
you need to add an override to |
@@ -129,6 +129,12 @@ in | |||
]; | |||
}; | |||
|
|||
pg_query = attrs: { | |||
postPatch = '' | |||
ln -s ${libpg_query}/lib ${libpg_query.name} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn’t work… And is pretty awful, but take a look at https://github.com/lfittl/pg_query/blob/master/ext/pg_query/extconf.rb#L8-L11
What do, @Mic92? :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the gem version in your project does not match the version on github: https://github.com/lfittl/pg_query/blob/v0.9.2/ext/pg_query/extconf.rb
It uses a different version of libpg_query. And also expects the header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, OK! I’ll look at this over the weekend.
What would we do, though, if we had two projects with each depending on a different version of pg_query
? We could depend only on one version of libpg_query
in this override, right? What then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this usually handled? @cstrahan
@michalrus are you still working on this? I see it stalled earlier, could you help push it forward if you still need this work to be merged? |
@ocharles I’d love to have this util in my If anyone knows how, please, help! |
Ok, I think it might be best to move this discussion to an issue, and perhaps trying to rally the troops via the mailing list. |
superseded by #41901 |
Motivation for this change
sqlint is useful (esp. with flycheck in Emacs)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)But I need help. Currently, building
pg_query-0.9.2
fails, because it’s a native extension and needs a native library… How to provide one ingemset.nix
?