Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Source Han Serif font #24624

Merged
merged 1 commit into from Apr 6, 2017
Merged

add Source Han Serif font #24624

merged 1 commit into from Apr 6, 2017

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Apr 4, 2017

Motivation for this change

Source Han Serif font is an OpenType pan-CJK serif font family by Adobe.
It contains Japanese, Korean, Traditional Chinese, and Simplified Chinese glyphs.
The font is licensed under SIL Open Font License.

https://github.com/adobe-fonts/source-han-serif
https://source.typekit.com/source-han-serif

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Tested with Inkscape.

@mention-bot
Copy link

@taku0, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dezgeg to be a potential reviewer.

Mic92
Mic92 reviewed Apr 4, 2017
View reviewed changes
pkgs/data/fonts/source-han-serif/default.nix
description = "${language} subset of an open source Pan-CJK serif typeface";
homepage = https://github.com/adobe-fonts/source-han-sans;
license = stdenv.lib.licenses.ofl;
platforms = stdenv.lib.platforms.unix;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to maintain this package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I want to maintain this package and source-han-sans, but I don't have a commit right.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add yourself as maintainer to the package. Sending in PRs is just fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amended.

@NeQuissimus
Copy link
Member

I am getting 404s when trying to build this:

> nix-build -A source-han-serif-japanese
these derivations will be built:
  /nix/store/snvnvwj2kzhvpq82b256ddv3c4iwxc3x-SourceHanSerifJ_EL-M.zip.drv
  /nix/store/yhrwin5z1hz1xw7igxb074k89kyi68k3-SourceHanSerifJ_SB-H.zip.drv
  /nix/store/f2xflwxgdl76rz7ljsvml9jdb57ha7wv-source-han-serif-japanese-1.000R.drv
building path(s) ‘/nix/store/9ln9zwri8l0w48m6cnwssrz1rxs96b8w-SourceHanSerifJ_EL-M.zip’
building path(s) ‘/nix/store/j077z4cg0x6fklpfgm2s2zpmbm1mgi94-SourceHanSerifJ_SB-H.zip’


trying https://github.com/adobe-fonts/source-han-serif/raw/f6cf97d92b22e7bd77e355a61fe549ae44b6de76/SubsetOTF/SourceHanSerifJ_SB-H.zip
trying https://github.com/adobe-fonts/source-han-serif/raw/f6cf97d92b22e7bd77e355a61fe549ae44b6de76/SubsetOTF/SourceHanSerifJ_EL-M.zip
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download SourceHanSerifJ_SB-H.zip from any mirror
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download SourceHanSerifJ_EL-M.zip from any mirror
builder for ‘/nix/store/yhrwin5z1hz1xw7igxb074k89kyi68k3-SourceHanSerifJ_SB-H.zip.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/f2xflwxgdl76rz7ljsvml9jdb57ha7wv-source-han-serif-japanese-1.000R.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/f2xflwxgdl76rz7ljsvml9jdb57ha7wv-source-han-serif-japanese-1.000R.drv’ failed

@taku0
add source-han-serif-japanese, source-han-serif-korean, source-han-se…
2994f14 
…rif-simplified-chinese, source-han-serif-traditional-chinese: An open source Pan-CJK serif typeface
@taku0
Copy link
Contributor Author

taku0 commented Apr 6, 2017

Fixed. It pointed wrong URLs. It happened to work on my machine because I saved archives to /nix/store manually with nix-store.

@NeQuissimus
Copy link
Member

LGTM now, thanks.

@NeQuissimus NeQuissimus merged commit 4984e7e into NixOS:master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@NeQuissimus NeQuissimus NeQuissimus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taku0 @mention-bot @NeQuissimus @Mic92