thunderbird, thunderbird-bin: 45.8.0 -> 52.0 #24623
Conversation
| wrapProgram "$out/bin/thunderbird" \ | ||
| --argv0 "$out/bin/.thunderbird-wrapped" \ | ||
| --prefix XDG_DATA_DIRS : "$GSETTINGS_SCHEMAS_PATH:" \ | ||
| --suffix XDG_DATA_DIRS : "$XDG_ICON_DIRS" |
There was a problem hiding this comment.
I suppose wrapGAppsHook can be also used here, right @abbradar?
| @@ -116,6 +119,8 @@ stdenv.mkDerivation { | |||
| stdenv.cc.cc | |||
| ]; | |||
|
|
|||
| buildInputs = [ makeWrapper gtk3 defaultIconTheme ]; | |||
There was a problem hiding this comment.
makeWrapper should go to nativeBuildInputs.
There was a problem hiding this comment.
Fixed. I will also fix firefox-bin after this PR is merged.
|
Passed nox-review locally on NixOS with sandboxing enabled. |
taku0
force-pushed
the
thunderbird-bin-52.0
branch
from
c4e79ac
to
f7d6b71
Compare
|
I'm trying to solve a crash in Thunderbird so I can merge this along with my fixes (most likely we need to disable system |
|
@abbradar Is the crash in Thunderbird caused by this change? |
|
@aristidb Nope, it's a separate problem, unrelated to this -- I'm just testing things in bulk. I still haven't solved it (plan to finish today or tomorrow) so if anybody wants he/she can merge this earlier. |
Motivation for this change
Various enhancements and changes.
“IMPORTANT: The way images are included in a compose window has changed. Images are now included as data URIs and not as references to parts of other messages or operating system files. This allows better interoperability with office packages such as MS Office or LibreOffice. Images linked from locations on the internet will no longer be downloaded and attached to the message automatically. This can be changed for each image individually via the Image Properties dialog or globally by setting the preference mail.compose.attach_http_images.”
https://www.mozilla.org/en-US/thunderbird/52.0/releasenotes/
Related commits: 90f5be3
Note that the calendar add-on (Lightning) does not seem to be compatible with 52 yet.
https://addons.mozilla.org/en-US/thunderbird/addon/lightning/
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)