nixos: networking cleanup #11529
Closed
nixos: networking cleanup #11529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @wkennington, @edolstra and @offlinehacker to be potential reviewers |
|
cc @nbp for module system questions |
|
Pinging everyone for the help. |
|
Maybe open a separate issue for the submodule warnings problem? At least it would be discoverable separately. |
5 tasks
|
Reopening for a rebased version. |
oxij
force-pushed
the
nixos-networking-cleanup
branch
from
6759496
to
df89873
Compare
oxij
changed the title
|
Pushing the current version maintained by SLNOS since #27688 now wants
to reimplement exactly the same thing.
The submodule bug still persists in the current nixos (this version has
an ugly workaround and no longer needs any help which didn't come), some
of the other changes of this branch were reimplemented in nixos in the
meantime.
|
|
Hm, is this superseded by #27688 for mainline NixOS? |
|
Yep. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NixOS networking module is a mess. I've been trying to do something about it for a while, and I think I did simplify it somewhat with this patch set, but it has one problem: deprecating/renaming options in submodules doesn't work.
mkRemovedOptionModuleandmkRenamedOptionModulegenerate a warning inside a submodule, but this warning never get's out to the top-level warnings.I tried to implement something that could possibly work, but historically all my attempts had failed. NixOS recently introduced
mkRemovedOptionModuleand friends, and I tried to use it, but it did not suffice too.I want users that define
subnetMaskto get errors, and to implement that behavior without top-level asserts, but all my attempts are either completely ignored in the process of evaluation because these errors don't get computed/propagated to top-level orsubnetMaskasserts produce errors even when it's not defined.Same problem with
*addressand*prefixLengthoptions.I actually have a continuation of this patch set that then breaks networking into a series of independent modules and adds new useful assertions, but I didn't merge it with the current master yet, and don't want to do it until this gets to work properly.