Skip to content

wla-dx-git: 2016-02-27 -> 2017-06-05 #27107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2017
Merged

wla-dx-git: 2016-02-27 -> 2017-06-05 #27107

merged 1 commit into from
Jul 4, 2017
+4 −3

Conversation

adamscott
Copy link
Contributor

  • Change to version 2017-06-05
  • Add version attribute
Motivation for this change

Added version attribute as it is easier:

  • to know that the package name is "wla-dx-git"
  • to update the version from now on
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @matthewbauer

Sorry, something went wrong.

@adamscott
wla-dx-git: 2016-02-27 -> 2017-06-05
6e91d26 
- Change to version 2017-06-05
- Add version attribute
@mention-bot
Copy link

@adamscott, thanks for your PR! By analyzing the history of the files in this pull request, we identified @matthewbauer, @vcunat and @globin to be potential reviewers.

@FRidh FRidh merged commit e31dff8 into NixOS:master Jul 4, 2017
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xABAB 0xABAB

Assignees
No one assigned
Labels
12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adamscott @mention-bot @0xABAB @FRidh @Janik-Haag