gogs: Fix cyclic dependency on darwin #27104
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LnL7
approved these changes
Jul 3, 2017
LnL7
approved these changes
Jul 3, 2017
| @@ -26,7 +26,9 @@ buildGoPackage rec { | |||
|
|
|||
| outputs = [ "bin" "out" "data" ]; | |||
|
|
|||
| postInstall = '' | |||
| postInstall = stdenv.lib.optionalString (stdenv.isDarwin) '' | |||
This fixes the "cycle detected in the references of" error when building on darwin. The fix is based on the solution in issue NixOS#18131.
knedlsepp
force-pushed
the
fix-gogs-on-darwin
branch
from
ba9928b to
7f7b74d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This fixes the "cycle detected in the references of" error when building
on darwin. The fix is based on the solution in issue #18131.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)