faker: 0.0.4 -> 0.7.17 (and related changes) #27106

langston-barrett · 2017-07-03T23:37:47Z

Motivation for this change

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

mention-bot · 2017-07-03T23:37:58Z

@siddharthist, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

langston-barrett · 2017-07-04T00:59:34Z

I can't tell if the Travis errors are legitimate...

NeQuissimus · 2017-07-04T01:14:36Z

I get the same errors when invoking nox-review wip locally.

======================================================================
ERROR: __main__ (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: __main__
Traceback (most recent call last):
  File "/nix/store/v96ayp4hp476fqabmx86vgvwcn8wb7f9-python3-3.6.1/lib/python3.6/unittest/loader.py", line 153, in loadTestsFromName
    module = __import__(module_name)
  File "/tmp/nix-build-dkimpy-0.6.1.drv-0/dkimpy-0.6.1/dkim/__main__.py", line 4, in <module>
    from tests import test_suite
ModuleNotFoundError: No module named 'tests'


----------------------------------------------------------------------
Ran 154 tests in 0.793s

FAILED (errors=1)
Test failed: <unittest.runner.TextTestResult run=154 errors=1 failures=0>
config.status: creating build/bin/b4b5-archfix
error: Test failed: <unittest.runner.TextTestResult run=154 errors=1 failures=0>
config.status: creating build/bin/rb-archfix
config.status: creating build/contrib/check_perms_grsecurity.py
builder for ‘/nix/store/9l97yy47i0npcq3idpjsqhbsp3x1k3x0-dkimpy-0.6.1.drv’ failed with exit code 1
error: build of ‘/nix/store/9l97yy47i0npcq3idpjsqhbsp3x1k3x0-dkimpy-0.6.1.drv’ failed
The invocation of "nix-build -A python27Packages.email_validator -A hash-slinger -A python36Packages.python-etcd -A python36Packages.sqlobject -A python36Packages.dkimpy -A python36Packages.ansible_2_2 -A python36Packages.email_validator -A dkimpy -A python27Packages.dns -A electrum-ltc -A python27Packages.ntfy -A dd-agent -A python36Packages.faker -A ntfy -A python36Packages.sleekxmpp -A python27Packages.sipsimple -A python27Packages.dkimpy -A python36Packages.ansible -A electrum-dash -A python27Packages.ansible_2_2 -A python27Packages.sleekxmpp -A mailman -A python36Packages.ukpostcodeparser -A electrum -A python27Packages.ansible_2_3 -A ansible -A python36Packages.dns -A python27Packages.python-etcd -A python27Packages.ansible2 -A python27Packages.sqlobject -A python27Packages.ansible -A python36Packages.ansible_2_1 -A python27Packages.FormEncode -A python36Packages.FormEncode -A kargo -A blink -A python27Packages.ukpostcodeparser -A python27Packages.faker -A python27Packages.ansible_2_1 -A python36Packages.ntfy -A errbot /home/nequi/dev/nixpkgs" failed

langston-barrett · 2017-07-05T17:39:27Z

@NeQuissimus Thanks for checking it out! I don't think that error is related to my changes. It also happens on master.

@leenaars Looks like you're the maintainer on that package, any input on what's causing those tests to fail?

langston-barrett · 2017-07-09T00:09:20Z

I believed I've fixed the build of dkimpy.

NeQuissimus · 2017-07-09T16:31:48Z

nox-review still fails for me though

Processing ./cli53-0.4.4-py2-none-any.whl
Processing ./dkimpy-0.6.2-py2-none-any.whl
Collecting argparse (from cli53==0.4.4)
  Could not find a version that satisfies the requirement argparse (from cli53==0.4.4) (from versions: )
No matching distribution found for argparse (from cli53==0.4.4)
Installing collected packages: dkimpy
builder for ‘/nix/store/vr5dn5g7v7y7239y65c7zjiyv11vvxgy-cli53-0.4.4.drv’ failed with exit code 1
error: build of ‘/nix/store/vr5dn5g7v7y7239y65c7zjiyv11vvxgy-cli53-0.4.4.drv’ failed
The invocation of "nix-build -A python27Packages.ansible_2_1 -A electrum -A python36Packages.dns -A python27Packages.ansible2 -A python27Packages.FormEncode -A python36Packages.faker -A cli53 -A blink -A python27Packages.python-etcd -A python36Packages.python-etcd -A ntfy -A mailman -A ansible -A python27Packages.ukpostcodeparser -A dkimpy -A python27Packages.sipsimple -A python27Packages.ansible_2_2 -A kargo -A python36Packages.ansible_2_1 -A python36Packages.sqlobject -A python36Packages.FormEncode -A python27Packages.email_validator -A python27Packages.ntfy -A python36Packages.ansible_2_2 -A python27Packages.dkimpy -A hash-slinger -A electrum-dash -A python36Packages.email_validator -A python27Packages.ansible -A python36Packages.sleekxmpp -A python36Packages.dkimpy -A python27Packages.faker -A python27Packages.sqlobject -A python36Packages.ntfy -A errbot -A python36Packages.ansible -A python27Packages.ansible_2_3 -A electrum-ltc -A python27Packages.dns -A dd-agent -A python36Packages.ukpostcodeparser -A python27Packages.sleekxmpp /home/nequi/dev/nixpkgs" failed

langston-barrett · 2017-07-10T18:06:02Z

@NeQuissimus Sorry to have wasted your time, I appreciate your patience and review. I've been having trouble running nox-review, which is why I didn't check before making this PR. I'll try to set up a container or virtual machine or something to test it, and ping you when I get that working.

NeQuissimus · 2017-07-10T19:13:12Z

@siddharthist No worries. I find it only works for me if I run it outside of nix-shell by installing it into my environment and then running nox-review wip directly.

langston-barrett · 2017-07-10T19:43:57Z

Yeah, for some reason I still get the error I linked to above 😢 Might have to wait for the resolution of #27288 or feedback on madjar/nox#65 before I can use nox-review and then fix this PR. Here's the command I used:

nox-review pr 27106

NeQuissimus · 2017-07-10T21:19:07Z

I was not even aware of the PR functionality :)

I have two aliases in my ~/.gitconfig:

prup = "!f() { git fetch upstream pull/${1}/head:pr-${1}; git checkout pr-${1}; }; f"
undo = reset HEAD~1 --mixed

Then I do this in my nixpkgs

git prup 27106
git undo # Repeat until all commits from PR are undone
nox-review wip

nox-review wip seems to work while nox-review pr 27106 does not...

langston-barrett · 2017-07-11T00:22:21Z

@NeQuissimus Is it possible that you're using a different version of nix? What happens when you run nix-env -qaPf . --out-path on master? That's how nox is producing the above error, I get the message:

error: attribute ‘webkitgtk24x’ missing, at /home/siddharthist/code/nixpkgs/pkgs/development/haskell-modules/hackage-packages.nix:202442:10

NeQuissimus · 2017-07-11T01:04:28Z

Works just fine.
Master (as of right now) lists all the good stuff :)

Also:

~ λ nix-env --version
nix-env (Nix) 1.11.11
~ λ readlink -e $(type -p nix-env) 
/nix/store/ypy3xhz1p5bf472nphhdq1z73khsx8rc-nix-1.11.11/bin/nix-env
~ λ readlink -e $(type -p nox-review)
/nix/store/jqbxpps9nmagav3fx328s59l42h8rl69-nox-0.0.5/bin/nox-review

FRidh · 2017-07-17T12:13:19Z

@siddharthist Could you rebase this and ping me afterwards?

langston-barrett · 2017-07-18T17:35:23Z

@FRidh I've rebased and tested the build of Faker and dkimpy

It also looks like nox-review just started working for me!! Now the build of neutron is failing (but it's also failing for me on master). It fails with a similar error to the travis build, both complaining about argparse.

langston-barrett · 2017-07-25T21:59:32Z

I've rebased again and fixed the build of sqlobject by updating FormEncode. Putting out fires... 🤕 🔥

There are still some errors in the nox-review:

neutron: This package is broken and marked as broken, nox doesn't skip broken packages
cli53: This package is broken but not marked. For now, I'm ignoring it
ryu: marked as broken
maybe more, I'm still working

langston-barrett · 2017-07-25T22:26:58Z

Actually, looks like ryu was the last of it. This is what nox-review wip --against master runs after commit 05d661a:

nix-build -A electrum -A python36Packages.sqlobject -A python27Packages.sqlobject -A python36Packages.FormEncode -A python36Packages.pysideShiboken -A python36Packages.spyder -A python36Packages.python-etcd -A python27Packages.email_validator -A python36Packages.pyside -A python36Packages.ansible -A ntfy -A python27Packages.ansible -A python27Packages.ansible_2_2 -A dkimpy -A electrum-dash -A python36Packages.ansible_2_2 -A python36Packages.ukpostcodeparser -A python27Packages.faker -A python27Packages.python-etcd -A python36Packages.dns -A hash-slinger -A python27Packages.sipsimple -A neutron -A dd-agent -A python27Packages.sleekxmpp -A python27Packages.dns -A python27Packages.ntfy -A python36Packages.faker -A python27Packages.ansible_2_1 -A ansible -A python27Packages.ukpostcodeparser -A python36Packages.ntfy -A electrum-ltc -A cli53 -A python27Packages.dkimpy -A blink -A python27Packages.ansible2 -A python27Packages.FormEncode -A kargo -A python27Packages.ryu -A python36Packages.ryu -A python36Packages.dkimpy -A mailman -A errbot -A python36Packages.sleekxmpp -A python27Packages.ansible_2_3 -A python36Packages.email_validator -A python36Packages.pysideTools -A python36Packages.ansible_2_1 .

without cli53, neutron, and ryu:

nix-build -A electrum -A python36Packages.sqlobject -A python27Packages.sqlobject -A python36Packages.FormEncode -A python36Packages.pysideShiboken -A python36Packages.spyder -A python36Packages.python-etcd -A python27Packages.email_validator -A python36Packages.pyside -A python36Packages.ansible -A ntfy -A python27Packages.ansible -A python27Packages.ansible_2_2 -A dkimpy -A electrum-dash -A python36Packages.ansible_2_2 -A python36Packages.ukpostcodeparser -A python27Packages.faker -A python27Packages.python-etcd -A python36Packages.dns -A hash-slinger -A python27Packages.sipsimple -A dd-agent -A python27Packages.sleekxmpp -A python27Packages.dns -A python27Packages.ntfy -A python36Packages.faker -A python27Packages.ansible_2_1 -A ansible -A python27Packages.ukpostcodeparser -A python36Packages.ntfy -A electrum-ltc -A python27Packages.dkimpy -A blink -A python27Packages.ansible2 -A python27Packages.FormEncode -A kargo -A python36Packages.dkimpy -A mailman -A errbot -A python36Packages.sleekxmpp -A python27Packages.ansible_2_3 -A python36Packages.email_validator -A python36Packages.pysideTools -A python36Packages.ansible_2_1 .

and that passes.

Note that the Travis build fails on cli53. If anyone else can confirm cli53 is broken on master, then I think this is ready to merge (maybe after marking cli53 as broken).

FRidh · 2017-07-26T08:06:09Z

Looks good! I'll just wait till some of the rebuilding is finished and then merge this.

langston-barrett · 2017-07-27T16:23:56Z

@FRidh Thanks for hanging in there with the review 😄 hopefully my PRs will be expedited now that nox-review is working for me.

FRidh · 2017-07-28T17:31:35Z

This is in staging now.

langston-barrett force-pushed the faker branch from f5a0f76 to a0f2a2b Compare July 3, 2017 23:47

langston-barrett force-pushed the faker branch from a0f2a2b to 41a598f Compare July 9, 2017 00:07

FRidh added the 6.topic: python label Jul 17, 2017

langston-barrett force-pushed the faker branch from 41a598f to 5601079 Compare July 18, 2017 17:35

jtojnar mentioned this pull request Jul 20, 2017

pythonPackages.faker: 0.0.4 -> 0.7.18 #27523

Closed

7 tasks

langston-barrett added 9 commits July 25, 2017 21:26

pythonPackages.dkimpy: 0.6.1 -> 0.6.2

b09969c

dnspython: 1.14.0 -> 1.15.0

8cde368

formencode: update for dnspython

54ac990

email_validator: init at 1.0.2

268221a

ukpostcodeparser: init at 1.1.0

b698c57

faker: 0.0.4 -> 0.7.17

8f30d35

pythonPackages.pysideShiboken: patch for Python 3.6

74f5ed1

pythonPackages.FormEncode: 1.3.0 -> 1.3.1

cfbdcef

pythonPackages.sqlobject: 3.0.0 -> 3.3.0

05d661a

langston-barrett force-pushed the faker branch from 5601079 to 05d661a Compare July 25, 2017 21:55

FRidh self-assigned this Jul 26, 2017

FRidh closed this Jul 28, 2017

langston-barrett deleted the faker branch July 28, 2017 19:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

faker: 0.0.4 -> 0.7.17 (and related changes) #27106

faker: 0.0.4 -> 0.7.17 (and related changes) #27106

langston-barrett commented Jul 3, 2017

mention-bot commented Jul 3, 2017

langston-barrett commented Jul 4, 2017

NeQuissimus commented Jul 4, 2017

langston-barrett commented Jul 5, 2017

langston-barrett commented Jul 9, 2017

NeQuissimus commented Jul 9, 2017

langston-barrett commented Jul 10, 2017

NeQuissimus commented Jul 10, 2017

langston-barrett commented Jul 10, 2017

NeQuissimus commented Jul 10, 2017

langston-barrett commented Jul 11, 2017

NeQuissimus commented Jul 11, 2017

FRidh commented Jul 17, 2017

langston-barrett commented Jul 18, 2017 •

edited

langston-barrett commented Jul 25, 2017 •

edited

langston-barrett commented Jul 25, 2017

FRidh commented Jul 26, 2017

langston-barrett commented Jul 27, 2017

FRidh commented Jul 28, 2017

faker: 0.0.4 -> 0.7.17 (and related changes) #27106

faker: 0.0.4 -> 0.7.17 (and related changes) #27106

Conversation

langston-barrett commented Jul 3, 2017

Motivation for this change

Things done

mention-bot commented Jul 3, 2017

langston-barrett commented Jul 4, 2017

NeQuissimus commented Jul 4, 2017

langston-barrett commented Jul 5, 2017

langston-barrett commented Jul 9, 2017

NeQuissimus commented Jul 9, 2017

langston-barrett commented Jul 10, 2017

NeQuissimus commented Jul 10, 2017

langston-barrett commented Jul 10, 2017

NeQuissimus commented Jul 10, 2017

langston-barrett commented Jul 11, 2017

NeQuissimus commented Jul 11, 2017

FRidh commented Jul 17, 2017

langston-barrett commented Jul 18, 2017 • edited

langston-barrett commented Jul 25, 2017 • edited

langston-barrett commented Jul 25, 2017

FRidh commented Jul 26, 2017

langston-barrett commented Jul 27, 2017

FRidh commented Jul 28, 2017

langston-barrett commented Jul 18, 2017 •

edited

langston-barrett commented Jul 25, 2017 •

edited