google-fonts: 2016-08-30 -> 2017-06-28 #27333
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sternenseemann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @manveru, @cmfwyp and @edolstra to be potential reviewers. |
vyp
reviewed
Jul 12, 2017
| @@ -2,18 +2,18 @@ | |||
|
|
|||
| stdenv.mkDerivation rec { | |||
| name = "google-fonts-${version}"; | |||
| version = "2016-08-30"; | |||
| version = "2016-07-28"; | |||
There was a problem hiding this comment.
Why is the date/version going backwards? Shouldn't it be like 2017-06-27 or something?
There was a problem hiding this comment.
Oh, I forgot changing the year, thanks!
sternenseemann
force-pushed
the
google-fonts
branch
from
8165ff4 to
08ef468
Compare
sternenseemann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Addition of fonts previously only avaiable via the website.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"