undaemonize: init at 2017-07-11 #27325
Merged
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure how I'm supposed to add software that isn't versioned, or if we have a policy on that. This is a very simple little tool that comes from here: https://github.com/nickstenning/undaemonize (and only has two commits). I could maybe call it v1.0, maybe @nickstenning has an opinion? |
Mic92
reviewed
Jul 12, 2017
| { stdenv, fetchFromGitHub }: | ||
|
|
||
| stdenv.mkDerivation { | ||
| name = "undaemonize"; |
There was a problem hiding this comment.
add the date <year>-<month>-<day> of the commit you referring to here as version.
Mic92
reviewed
Jul 12, 2017
| src = fetchFromGitHub { | ||
| repo = "undaemonize"; | ||
| owner = "nickstenning"; | ||
| rev = "master"; |
There was a problem hiding this comment.
add a concrete commit and no branch here. Otherwise it will break if new commits are added.
Mic92
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)