Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tom smeets hidlisten #27467

Closed
wants to merge 4 commits into from
Closed

Tom smeets hidlisten #27467

wants to merge 4 commits into from

Conversation

bennofs
Copy link
Contributor

@bennofs bennofs commented Jul 18, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@bennofs, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @zraexy and @vcunat to be potential reviewers.

@bennofs
Copy link
Contributor Author

bennofs commented Jul 18, 2017 •
edited

oops sorry i messed up :/ (wanted to create a PR locally in my repo)

@bennofs bennofs closed this Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bennofs @mention-bot @TomSmeets