Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkmanager_l2tp: fix build without Gnome #27466

Closed

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Jul 18, 2017

Motivation

networkmanager_l2tp fails to build if withGnome = false because the included autogen.sh script is not run with our configureFlags. To avoid running configure twice, I copied the relevant commands from autogen.sh into preConfigure.

Testing

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Sep 30, 2017

Fixed by #27541?

@ttuegel ttuegel closed this Dec 13, 2017
@ttuegel ttuegel deleted the bugfix/networkmanager-without-gnome branch December 13, 2017 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants