Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

programs.zsh.ohMyZsh: add package option to make package overrides on module-base easier #27469

Merged
merged 1 commit into from
Jul 22, 2017
Merged

programs.zsh.ohMyZsh: add package option to make package overrides on module-base easier #27469

merged 1 commit into from
Jul 22, 2017

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jul 18, 2017

Motivation for this change

To override the oh-my-zsh package easier (e.g. adding patches from the oh-my-zsh repo that weren't accepted yet) a package option is helpful.

Now sth. like this is possible:

{ pkgs, ... }:
{
  programs.zsh = {
    enable = true;
    ohMyZsh = {
      enable = true;
      package = pkgs.oh-my-zsh.overrideAttrs (a: { });
    };
  };
}
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jul 19, 2017

Don't forget line 63.

@Ma27
Copy link
Member Author

Ma27 commented Jul 19, 2017

done, thanks ;-)

@Mic92 Mic92 merged commit b1bff52 into NixOS:master Jul 22, 2017
@Ma27 Ma27 deleted the oh-my-zsh/make-pkg-configurable branch July 22, 2017 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants