Skip to content

hotspot: init at 1.0.0 #27181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

hotspot: init at 1.0.0 #27181

wants to merge 2 commits into from
+67 −0

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jul 6, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@nh2 nh2 mentioned this pull request Jul 6, 2017
Closed
@FRidh FRidh changed the title Add hotspot hotspot: init at 1.0.0 Jul 7, 2017
FRidh
FRidh reviewed Jul 7, 2017
View reviewed changes
pkgs/development/tools/analysis/hotspot/default.nix Outdated
];
nativeBuildInputs = [ makeQtWrapper ];

patchPhase = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postPatch. Try not to override default phases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@nh2
Copy link
Contributor Author

nh2 commented Jul 9, 2017

I need to revise this due to commit f3ce852 which removed makeQtWrapper (apparently it is no longer needed) (I cannot find why it is no longer needed though, maybe you can enlighten me @ttuegel).

@nh2
Copy link
Contributor Author

nh2 commented Jul 9, 2017

I need to revise this due to commit f3ce852 which removed makeQtWrapper

Done. Please take another look.

@bjornfor
Copy link
Contributor

bjornfor commented Jul 9, 2017

Builds and runs. Applied to master (a37f3a3, 35e9127). Thanks!

@bjornfor bjornfor closed this Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@0xABAB 0xABAB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nh2 @bjornfor @FRidh @0xABAB