Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package sublime-dev build. #26718

Closed
wants to merge 1 commit into from
Closed

Package sublime-dev build. #26718

wants to merge 1 commit into from

Conversation

nc6
Copy link
Contributor

@nc6 nc6 commented Jun 19, 2017

Motivation for this change

Additional sublime text 3 builds are available as 'dev' builds, which tend to move ahead of the officially released builds.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@NeQuissimus
Copy link
Member

We should probably have a note somewhere that says that a license is required

@jtojnar
Copy link
Contributor

jtojnar commented Nov 15, 2017

It looks like it should be possible to share most of the file with stable version. Could it be factored out to common.nix?

@MasseGuillaume MasseGuillaume mentioned this pull request Apr 3, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Apr 24, 2018

Resolved by #38383

@jtojnar jtojnar closed this Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants