csmith: init at 2.3.0, pull in Sys::CPU as dependency. #27095
Conversation
| postInstall = '' | ||
| substituteInPlace $out/bin/compiler_test.pl \ | ||
| --replace '$CSMITH_HOME/runtime' $out/include/${name} \ | ||
| --replace ' ''${CSMITH_HOME}/runtime' " $out/include/${name}" \ |
There was a problem hiding this comment.
Maybe I am wrong but those single quotes seem wrong. I guess you mean something like --replace '${CSMITH_HOME}/runtime' " $out/include/${name}" \
There was a problem hiding this comment.
Basically, but if written that way (`--replace '${CSMITH_HOME}/runtime') Nix will try to substitute for a 'CSMITH_HOME' variable, here I'm basically escaping it so the script actually contains the dollar-sign and brace characters.
| description = "A random generator of C programs"; | ||
| homepage = "https://embed.cs.utah.edu/csmith"; | ||
| # Officially, the license is this: https://github.com/csmith-project/csmith/blob/master/COPYING | ||
| license = licenses.bsd; |
There was a problem hiding this comment.
licenses.bsd is not a valid option. This looks like a 2-clause BSD license with is called licenses.bsd2. See https://github.com/NixOS/nixpkgs/blob/master/lib/licenses.nix#L78
There was a problem hiding this comment.
I didn't think so, but I thought it'd break if it didn't exist :3. Thanks, I'll fix that!
There was a problem hiding this comment.
It broke. Look at the last travis build :-)
There was a problem hiding this comment.
Interesting, well regardless I should've checked :). But I'll see what it's doing to test things that I'm not! 👍
|
Thanks! |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"(new package, there aren't any)./result/bin/)