Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maxx: init at 1.1.0 #27096

Merged
merged 4 commits into from Aug 25, 2017
Merged

maxx: init at 1.1.0 #27096

merged 4 commits into from Aug 25, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 3, 2017 •
edited by ghost

Motivation for this change

Add MaXX - retro desktop environment
http://www.maxxinteractive.com/

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@gnidorah, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @nbp and @edolstra to be potential reviewers.

0xABAB
0xABAB reviewed Jul 4, 2017
View reviewed changes
pkgs/desktops/maxx/default.nix Outdated

buildPhase = ''
while IFS= read -r -d $'\0' i; do
if ! isELF "$i"; then continue; fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just indent the if block, remove the ! and continue.

0xABAB
0xABAB reviewed Jul 4, 2017
View reviewed changes
pkgs/desktops/maxx/default.nix Outdated
done < <(find "." -type f -print0)

substituteInPlace bin/adminterm \
--replace /bin/bash /bin/sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bash and sh are programs which interpret different languages, so you are potentially introducing a bug here.

If the upstream program is really a sh program, then you should use ${stdenv.shell}, and inform upstream to fix their system.

0xABAB
0xABAB reviewed Jul 4, 2017
View reviewed changes
pkgs/desktops/maxx/default.nix

srcs = [
(fetchurl {
url = "http://maxxinteractive.com/downloads/${version}/FEDORA/MaXX-${version}-NO-ARCH.tar.gz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ask upstream to provide sources in a location not mentioning the name of a Linux distribution.

0xABAB
0xABAB reviewed Jul 4, 2017
View reviewed changes
pkgs/desktops/maxx/default.nix Outdated

installPhase = ''
maxx=$out/opt/MaXX
mkdir -p $maxx $out/share
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"$maxx"

0xABAB
0xABAB reviewed Jul 4, 2017
View reviewed changes
pkgs/desktops/maxx/default.nix Outdated
maxx=$out/opt/MaXX
mkdir -p $maxx $out/share

mv * $maxx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mv -- ./* "$maxx"

0xABAB
0xABAB reviewed Jul 4, 2017
View reviewed changes
pkgs/desktops/maxx/default.nix Outdated
longDescription = ''
The MaXX Interactive Desktop a.k.a. The MaXX Desktop is the continuation
of the 5dwm.org implementation released many years back. So don’t be
mistaken, there is only one implementation of the SGI Desktop on Linux.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fairly confusing for someone who has no idea what this sub culture is about. If you want to say this is not some official implementation, then use the word "official" somewhere to stress that this isn't that.

0xABAB
0xABAB reviewed Jul 4, 2017
View reviewed changes
pkgs/desktops/maxx/default.nix Outdated
The MaXX Interactive Desktop a.k.a. The MaXX Desktop is the continuation
of the 5dwm.org implementation released many years back. So don’t be
mistaken, there is only one implementation of the SGI Desktop on Linux.
Our goal is to bring to the masses this great user experience which focus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filling long descriptions is nice, but it's also not intended as a Wikipedia page, AFAIK. So, please be a bit more compact.

0xABAB
0xABAB approved these changes Jul 4, 2017
View reviewed changes
Copy link
Contributor

@0xABAB 0xABAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some missing double quotes, but otherwise this is ready. I would be surprised if the number of users of this thing in NixOS is going to be higher than 1 in the next 5 years.

@0xABAB
Copy link
Contributor

0xABAB commented Jul 10, 2017

@Mic92 Please merge this. It's not important enough to discuss pretty much anything about it (because there are no known users(!)).

@ghost ghost closed this Jul 23, 2017
@ghost ghost reopened this Jul 23, 2017
@ghost ghost changed the title maxx: init at 1.0.0 maxx: init at 1.1.0 Aug 4, 2017
@ghost
Copy link
Author

ghost commented Aug 22, 2017 •
edited by ghost

@Mic92 The package has been updated to work on other distros in addition to NixOS. However, this link need to be created manually there:

ln -s /nix/<maxx-package>/opt/MaXX /opt/

Is it possible to create it automatically somehow? In NixOS I just use system.activationScripts.setup-maxx in module.

@ghost ghost mentioned this pull request Aug 24, 2017
Merged
8 tasks
@Mic92
Copy link
Member

Mic92 commented Aug 24, 2017

oh, this looks pretty ugly. I think it would be better to redirecting reads to /opt to $out/opt using libredirect. Here is an example: https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/security/enpass/default.nix#L88

@ghost
Copy link
Author

ghost commented Aug 24, 2017

@Mic92 Cool it helped, thanks :-)

@Mic92 Mic92 merged commit ddf540d into NixOS:master Aug 25, 2017
@Mic92
Copy link
Member

Mic92 commented Aug 25, 2017

Thanks!

@ghost ghost deleted the maxx branch August 25, 2017 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mention-bot @0xABAB @Mic92 @pSub