Add NIKOLA_SHOW_TRACEBACKS environment variable #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
|
(FYI, I added it to my |
|
If this wasn't already merged, I would have suggested making NIKOLA_DEBUG a non-boolean option. Or, at least accept other values for levels of verbosity (with '1', 'true', 'yes' defaulting to current behavior.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not showing tracebacks to end-users is generally fine, but as a developer, it’s pretty annoying. On the other hand,
NIKOLA_DEBUG=1floods the console with useless Yapsy debug messages.So, the fix: add
NIKOLA_SHOW_TRACEBACKSthat shows tracebacks but no debug stuff (as a middle ground).