Skip to content

libunwind: fix version macros #27099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2017
Merged

libunwind: fix version macros #27099

merged 1 commit into from
Jul 3, 2017
+17 −0

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Jul 3, 2017

Motivation for this change

Fixes julia_05 build: #26891 (comment)
Upstream bug: libunwind/libunwind#30

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@vcunat vcunat self-assigned this Jul 3, 2017
vcunat
vcunat approved these changes Jul 3, 2017
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK. Tested the julia-0.5 build, too.

@vcunat
Copy link
Member

vcunat commented Jul 3, 2017

Fast-forward to master :-)

@vcunat vcunat merged commit 9ccdf60 into NixOS:master Jul 3, 2017
@vbgl
Copy link
Contributor

vbgl commented Jul 4, 2017

Many thanks.

@orivej orivej deleted the libunwind branch July 6, 2017 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat

Assignees

@vcunat vcunat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @vcunat @vbgl