buildbot: 0.9.7 -> 0.9.9.post2 #27094

nand0p · 2017-07-03T18:52:32Z

adds grid-view plugin
module fixup
tested on nixos

0xABAB · 2017-07-04T06:09:09Z

pkgs/development/python-modules/pympler/default.nix

+
+  doCheck = !stdenv.isDarwin;
+
+  # Remove test asizeof.flatsize(), broken and can be missed as


Not a sentence and please contact upstream for this.

0xABAB · 2017-07-04T06:11:05Z

pkgs/development/tools/build-managers/buildbot/default.nix

@@ -83,7 +83,7 @@ let

    meta = with stdenv.lib; {
      homepage = http://buildbot.net/;
-      description = "Continuous integration system that automates the build/test cycle";
+      description = "Buildbot is an open-source continuous integration framework for automating software build, test, and release processes.";


I like this.

no dot at the end

0xABAB · 2017-07-04T06:13:11Z

pkgs/development/tools/build-managers/buildbot/plugins.nix

    meta = with stdenv.lib; {
      homepage = http://buildbot.net/;
-      description = "Buildbot Packaging Helper";
+      description = "Buildbot UI";


Do you mean a web interface?

0xABAB · 2017-07-04T06:13:54Z

pkgs/development/tools/build-managers/buildbot/plugins.nix

    };

    meta = with stdenv.lib; {
      homepage = http://buildbot.net/;
-      description = "Buildbot UI";
+      description = "Buildbot Console View Plugin";


Provides a command line interface for Buildbot

0xABAB · 2017-07-04T06:15:36Z

pkgs/development/tools/build-managers/buildbot/plugins.nix

    meta = with stdenv.lib; {
      homepage = http://buildbot.net/;
-      description = "Buildbot Console View Plugin";
+      description = "Buildbot Waterfall View Plugin";


Can we get a long description too, since https://pypi.python.org/pypi/buildbot-waterfall-view also doesn't bother to give one?

0xABAB · 2017-07-04T06:16:53Z

nixos/modules/services/continuous-integration/buildbot/master.nix

-        # NOTE: call twistd directly with stdout logging for systemd
-        #ExecStart = "${cfg.package}/bin/buildbot start --nodaemon ${cfg.buildbotDir}";
-        ExecStart = "${pkgs.python27Packages.twisted}/bin/twistd -n -l - -y ${cfg.buildbotDir}/buildbot.tac";
+        ExecStart = "${cfg.package}/bin/buildbot start --nodaemon ${cfg.buildbotDir}";


${cfg.buildbotDir} doesn't work when it contains spaces.

yes, i think that is the correct expected behavior on linux/unix systems.

How can you expect something not to work? It clearly can work by properly escaping the argument.

buildbotDir containing whitespace didn't work before this PR, so it's not really the job of this PR to fix it.

@edolstra OK, perhaps there has been a misunderstanding, but I expect that every replacement line committed does not contain any potential flaw. So, while it might be true that BuildBot currently does not support spaces, at some point that limitation might be gone. In that case a version with properly escaped arguments would just work.

I don't think we should encourage bad practices.

If, on the other hand you mean that it's OK to open PRs for things that just make things slightly better as opposed to fixing things completely, then that's a policy which seems questionable.

The way I see it is that if an author modifies an existing line, they are reintroducing the same mistake, i.e. creating a bug.

I have the impression that you see this differently.

you mean that it's OK to open PRs for things that just make things slightly better as opposed to fixing things completely yes. we have been maintaining the buildbot package iteratively.

@0xABAB That's right, the PR should not introduce regressions. It does not have to reach a state of perfection.

FRidh

Thanks for the update. Some minor fixes are needed and then I think its ready to go in.

FRidh · 2017-07-04T07:09:36Z

pkgs/development/python-modules/pympler/default.nix

+  doCheck = !stdenv.isDarwin;
+
+  # Remove test asizeof.flatsize(), broken and can be missed as
+  patchPhase = ''


FRidh · 2017-07-04T07:09:59Z

pkgs/development/python-modules/pympler/default.nix

+    sha256 = "0mhyxqlkha98y8mi5zqcjg23r30mgdjdzs05lghbmqfdyvzjh1a3";
+  };
+
+  doCheck = !stdenv.isDarwin;


Why not on Darwin? Leave a comment.

FRidh · 2017-07-04T07:10:42Z

pkgs/development/python-modules/pympler/default.nix

+
+  meta = with stdenv.lib; {
+    homepage = http://pythonhosted.org/Pympler/;
+    description = "A development tool to measure, monitor and analyze the memory behavior of Python objects.";


no dot at the end

FRidh · 2017-07-04T07:10:51Z

pkgs/development/tools/build-managers/buildbot/default.nix

@@ -83,7 +83,7 @@ let

    meta = with stdenv.lib; {
      homepage = http://buildbot.net/;
-      description = "Continuous integration system that automates the build/test cycle";
+      description = "Buildbot is an open-source continuous integration framework for automating software build, test, and release processes.";


no dot at the end

FRidh · 2017-07-04T07:12:07Z

pkgs/development/tools/build-managers/buildbot/plugins.nix

@@ -1,85 +1,82 @@
 { stdenv, pythonPackages }:

-let
-  buildbot-pkg = pythonPackages.buildPythonPackage rec {
+# NOTE: buildbot plugins available as wheels


They only distribute wheels? Bleh...

No, they just don't follow their own documentation: buildbot/buildbot#3409.

For the main release there is now a tar.gz. I didn't check for the plugins; that might be different.

0xABAB · 2017-07-05T17:51:50Z

pkgs/development/tools/build-managers/buildbot/plugins.nix


    src = pythonPackages.fetchPypi {
      inherit pname version;
-      sha256 = "0p351r10y42gwgxb2qg7xlsbhmnzdmqp6h4922l0yfii3pzmrdzv";
+      sha256 = "0000000000000000000000000000000000000000000000000000";


That's unlikely to be the correct hash.

waiting on the buildbot maintainers @tardyp to publish the source tarballs, so as to update this hash buildbot/buildbot#3409

If the lack of sdist is preventing this from going in, then let's just use wheels or tarballs from GitHub.

0xABAB · 2017-07-05T17:53:00Z

pkgs/development/tools/build-managers/buildbot/plugins.nix

@@ -25,14 +25,14 @@ in {
  www = pythonPackages.buildPythonPackage rec {
    name = "${pname}-${version}";
    pname = "buildbot_www";
-    version = "0.9.7";
+    version = "0.9.9.post1";

    # NOTE: wheel is used due to buildbot circular dependency


Is anyone supposed to understand what you mean by that comment?

.post1 is not a comment, it is the actual release version

@nand0p I was talking about the only comment visible, which I suppose is not part of this PR, but still.
# NOTE: wheel is used due to buildbot circular dependency

Please change your tone in pull request reviews. This is not the linux ml. The semantics of format is documented in buildPythonPackage.

tardyp · 2017-07-07T13:40:58Z

Guys, I've published 0.9.9.post2 for you yesterday.
You should have tarballs and wheels properly uploaded, on top of a couple of bugfixes.
https://pypi.python.org/pypi/buildbot/0.9.9.post2

- adds grid-view plugin - module fixup - tested on nixos

nand0p · 2017-07-07T14:25:49Z

@FRidh ready_for_review

pSub added the 8.has: package (update) label Jul 3, 2017

nand0p force-pushed the buildbot-0.9.9 branch 2 times, most recently from 32ef20f to 8e22f46 Compare July 3, 2017 21:00

0xABAB reviewed Jul 4, 2017

View reviewed changes

FRidh requested changes Jul 4, 2017

View reviewed changes

nand0p force-pushed the buildbot-0.9.9 branch from 8e22f46 to 49cf4d8 Compare July 5, 2017 16:01

0xABAB reviewed Jul 5, 2017

View reviewed changes

buildbot: 0.9.7 -> 0.9.9.post2

f6a7b85

- adds grid-view plugin - module fixup - tested on nixos

nand0p force-pushed the buildbot-0.9.9 branch from 49cf4d8 to f6a7b85 Compare July 7, 2017 14:01

nand0p changed the title ~~buildbot: 0.9.7 -> 0.9.9~~ buildbot: 0.9.7 -> 0.9.9.post2 Jul 7, 2017

FRidh approved these changes Jul 7, 2017

View reviewed changes

FRidh merged commit ea5b2df into NixOS:master Jul 7, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

buildbot: 0.9.7 -> 0.9.9.post2 #27094

buildbot: 0.9.7 -> 0.9.9.post2 #27094

nand0p commented Jul 3, 2017 •

edited

Loading

0xABAB Jul 4, 2017

0xABAB Jul 4, 2017

FRidh Jul 4, 2017

0xABAB Jul 4, 2017

0xABAB Jul 4, 2017

0xABAB Jul 4, 2017

0xABAB Jul 4, 2017

nand0p Jul 5, 2017

0xABAB Jul 7, 2017

edolstra Jul 7, 2017

0xABAB Jul 7, 2017

nand0p Jul 7, 2017

edolstra Jul 7, 2017

FRidh left a comment

FRidh Jul 4, 2017

FRidh Jul 4, 2017

FRidh Jul 4, 2017

FRidh Jul 4, 2017

FRidh Jul 4, 2017

0xABAB Jul 4, 2017

0xABAB Jul 4, 2017

0xABAB Jul 5, 2017

nand0p Jul 5, 2017 •

edited

Loading

FRidh Jul 7, 2017

0xABAB Jul 5, 2017

nand0p Jul 5, 2017

0xABAB Jul 6, 2017

Mic92 Jul 7, 2017

tardyp commented Jul 7, 2017

nand0p commented Jul 7, 2017


		doCheck = !stdenv.isDarwin;

		# Remove test asizeof.flatsize(), broken and can be missed as

buildbot: 0.9.7 -> 0.9.9.post2 #27094

buildbot: 0.9.7 -> 0.9.9.post2 #27094

Conversation

nand0p commented Jul 3, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FRidh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nand0p Jul 5, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tardyp commented Jul 7, 2017

nand0p commented Jul 7, 2017

nand0p commented Jul 3, 2017 •

edited

Loading

nand0p Jul 5, 2017 •

edited

Loading