dr14_tmeter: init at 1.0.16 #27092
Merged
dr14_tmeter: init at 1.0.16 #27092
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adisbladis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @zraexy and @vcunat to be potential reviewers. |
pSub
requested changes
Jul 3, 2017
|
|
||
| let | ||
| inherit (python3Packages) buildPythonApplication; | ||
| in buildPythonApplication rec { |
There was a problem hiding this comment.
You can just write python3Packages.buildPythonApplication.
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Compute the DR14 of a given audio file according to the procedure described by the Pleasurize Music Foundation"; | ||
| license = stdenv.lib.licenses.gpl3Plus; |
There was a problem hiding this comment.
Using with stdenv.lib you bring everything into scope that is in stdenv.lib. Therefore you can just write license = licenses.gpl3Plus;
| description = "Compute the DR14 of a given audio file according to the procedure described by the Pleasurize Music Foundation"; | ||
| license = stdenv.lib.licenses.gpl3Plus; | ||
| homepage = http://dr14tmeter.sourceforge.net/; | ||
| maintainers = [ stdenv.lib.maintainers.adisbladis ]; |
There was a problem hiding this comment.
Same thing here: maintainers = [ maintainers.adisbladis ];.
adisbladis
force-pushed
the
add_dr14_tmeter
branch
from
7ac9da8 to
c6f5726
Compare
|
@pSub Changes made |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Useful tool for checking dynamic range (DR14) of audio files.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)