Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghcHEAD: Actually split docs into their own output #26775

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

Ericson2314
Copy link
Member

Motivation for this change

I put outputs = ... in the wrong spot in the last PR, oops. Sorry about that.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I put `outputs = ...` in the wrong spot in the last PR, oops. Sorry
about that.
@Ericson2314 Ericson2314 requested a review from peti June 22, 2017 20:59
@Ericson2314 Ericson2314 merged commit f571ad4 into NixOS:master Jun 22, 2017
@Ericson2314 Ericson2314 deleted the ghc-head-docs branch June 22, 2017 21:11
@peti
Copy link
Member

peti commented Jun 23, 2017

????

What was this all about?

@vcunat
Copy link
Member

vcunat commented Jun 23, 2017

@peti: the binding was only in let-declaration, not in the derivation.

@peti
Copy link
Member

peti commented Jun 23, 2017

Oh.

@Ericson2314
Copy link
Member Author

Sorry I was not clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants