Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix] RO Aerobee engine plume #1692

Merged
merged 1 commit into from Jul 8, 2017
Merged

[Bug Fix] RO Aerobee engine plume #1692

merged 1 commit into from Jul 8, 2017

Conversation

PhineasFreak
Copy link
Contributor

@PhineasFreak PhineasFreak commented Jun 26, 2017 •
edited

Change log:

  • Fix the flare position.
  • Remove the fxOffset parameter (now patched via the global RealPlume engine patcher).

Notes:

  • Same issue as with the 1 kN thruster. Any parts that define AFTER RealPlume passes might also be broken.

@PhineasFreak PhineasFreak changed the title [Bug Fix] RO Aerobee engine plume fix [Bug Fix] RO Aerobee engine plume Jun 26, 2017
@Theysen
Copy link
Contributor

Theysen commented Jun 26, 2017

I submitted a 1 kN plume fix lately which is already merged. Is there still issues after fixing the position and size manually?

@PhineasFreak
Copy link
Contributor Author

PhineasFreak commented Jun 26, 2017 •
edited

@Theysen No, it is OK. You replaced the localPosition Z value with the one from the AFTER patch so it will work the same:

RealismOverhaul/GameData/RealismOverhaul/RealPlume_Configs/Squad/microEngine.cfg

Line 23 in 9b59455

localPosition = 0.0, 0.0, -0.78

While previously this was done via the AFTER pass:

RealismOverhaul/GameData/RealismOverhaul/RealPlume_Configs/Squad/microEngine.cfg

Lines 66 to 83 in 9b59455

// ==================================================
// Generic 1 kN thruster flare configuration.
// ==================================================
@PART[microEngine]:FOR[zzRealPlume]:NEEDS[SmokeScreen]
{
@EFFECTS
{
@Hypergolic-OMS-White
{
@MODEL_MULTI_SHURIKEN_PERSIST[flare]
{
@localPosition = 0.0, 0.0, -0.85
@fixedScale = 0.05
}
}
}
}
(note the line 78)

(BTW the above piece of code is also useless now)

Offtopic: The best way to create/configure/update the plumes now is via the flare/plumeScale and flare/Plume position (no idea why these are not used by default, the localPosition and fixedScale have many drawbacks). I also specifically pointed out the usefulness these fields when i updated the RO RealPlume config guide...

Edit: Also, the 1 kN thruster plume worked correctly in my install (KSP 1.2.2) so i suspect that something is/was blocking the AFTER pass to operate as expected (so no more correct flare position and scale).

@NathanKell NathanKell merged commit 56e794c into KSP-RO:master Jul 8, 2017
@PhineasFreak PhineasFreak deleted the RO-Aerobee-Plume-Update branch July 12, 2017 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PhineasFreak @Theysen @NathanKell