Killed sllides #2854
Merged
Killed sllides #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 26, 2017 13:33
Kwpolska
approved these changes
Jun 27, 2017
| @@ -80,7 +80,7 @@ Nikola can't do: | |||
| * An Issue tracker | |||
| * Anything with forms, really (except for `comments`_!) | |||
|
|
|||
| Keep in mind that "static" doesn't mean **boring**. You can have animations, slides | |||
| Keep in mind that "static" doesn't mean **boring**. You can have animations | |||
There was a problem hiding this comment.
I don’t think anyone would have parsed this as the slides directive.
|
I think you forgot to remove a slides specific test :) |
felixfontein
added a commit
that referenced
this pull request
Jul 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will add them as a plugin in the plugins repo in a separate PR.