Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yade: init at 2017.01a #26873

Closed
wants to merge 7 commits into from
Closed

Yade: init at 2017.01a #26873

wants to merge 7 commits into from

Conversation

remche
Copy link

@remche remche commented Jun 26, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm joachifm mentioned this pull request Jun 27, 2017
Closed
7 tasks
@0xABAB
Copy link
Contributor

0xABAB commented Jun 28, 2017

I agree with the other reviewers.

FRidh
FRidh requested changes Jul 27, 2017
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • remove excessive white space
  • refer to package from all-packages.nix

pkgs/applications/science/physics/yade/default.nix Outdated

pythonPackages = python27Packages;

minieigen = pythonPackages.buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

pkgs/applications/science/physics/yade/default.nix
src = fetchFromGitHub {
owner = "eudoxos";
repo = "minieigen";
rev = "7bd0a2e823333477a2172b428a3801d9cae0800f";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there no stable release?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no :(

pkgs/applications/science/physics/yade/default.nix Outdated

buildInputs = [ unzip pythonPackages.boost boost eigen3_3 ];

patchPhase = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postPatch

pkgs/applications/science/physics/yade/default.nix Outdated
boost
cgal
loki
python27Full
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use python27Full. What do you need?

pkgs/applications/science/physics/yade/default.nix Outdated
matplotlib
];

src = fetchurl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fetch from GitHub
https://github.com/yade/trunk/releases

pkgs/applications/science/physics/yade/default.nix
@@ -0,0 +1,111 @@
{ stdenv, fetchurl, fetchFromGitHub, pkgconfig, cmake, makeWrapper, python27Packages,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is specifically python27 needed? If both 2.7 and 3.x are supported, use python or pythonPackages.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

pkgs/applications/science/physics/yade/default.nix
minieigen
];

pythonPath = with pythonPackages; [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does yade provide Python modules?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@matthewbauer
Copy link
Member

@GrahamcOfBorg build yade

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: yade

Partial log (click to expand)

Cannot nix-instantiate `yade' because:
error: while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:113:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:19987:10:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:72:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:117:8:
undefined variable 'unzip' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/science/physics/yade/default.nix:19:23

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: yade

Partial log (click to expand)

Cannot nix-instantiate `yade' because:
�[31;1merror:�[0m while evaluating 'callPackageWith' at �[1m/home/ofborg/ofborg1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c1/lib/customisation.nix�[0m:113:35, called from �[1m/home/ofborg/ofborg1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c1/pkgs/top-level/all-packages.nix�[0m:19987:10:
while evaluating 'makeOverridable' at �[1m/home/ofborg/ofborg1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c1/lib/customisation.nix�[0m:72:24, called from �[1m/home/ofborg/ofborg1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c1/lib/customisation.nix�[0m:117:8:
undefined variable 'unzip' at �[1m/home/ofborg/ofborg1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-7c6f434c1/pkgs/applications/science/physics/yade/default.nix�[0m:19:23

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: yade

Partial log (click to expand)

Cannot nix-instantiate `yade' because:
�[31;1merror:�[0m while evaluating 'callPackageWith' at �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/lib/customisation.nix�[0m:113:35, called from �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/pkgs/top-level/all-packages.nix�[0m:19987:10:
while evaluating 'makeOverridable' at �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/lib/customisation.nix�[0m:72:24, called from �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/lib/customisation.nix�[0m:117:8:
undefined variable 'unzip' at �[1m/var/lib/gc-of-borg/nix-test-rs-28/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-28/pkgs/applications/science/physics/yade/default.nix�[0m:19:23

matthewbauer
matthewbauer requested changes Apr 21, 2018
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eval errors

@aanderse
Copy link
Member

@remche any motivation to continue with this PR?

@remche
Copy link
Author

remche commented May 29, 2019

nop, let's close.

@remche remche closed this May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@matthewbauer matthewbauer matthewbauer requested changes

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 8.has: package (new)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@remche @0xABAB @matthewbauer @GrahamcOfBorg @aanderse @Mic92 @FRidh @joachifm @samueldr