pythonPackages.mechanize: 0.2.5 -> 0.3.5 #27191
Closed
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@calvertvl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer. |
0xABAB
approved these changes
Jul 6, 2017
0xABAB
suggested changes
Jul 6, 2017
calvertvl
force-pushed
the
fix_calibre_mechanize-0.3.5
branch
from
f1528ce to
0825244
Compare
|
Let's see if propagating html5lib fixes it...I thought there was a problem in calibre if I included it in propagatedBuildInputs, but re-testing seems to indicate it is a non-issue. |
|
Looks like that worked. There's some sort of build failure for weboob on darwin, but I don't have any way to test that (and it looks like it was broken anyway, and is not related to mechanize or html5lib). |
pSub
added
the
8.has: package (update)
|
This breaks calibre because our version of calibre depends on another version of html5lib. Let's see what we can do about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Calibre command-line tools used against a running calibre now use an HTTP interface (as of 3.0).
When calibre is built against older versions of mechanize (such as 0.2.5), these tools fail. After updating to 0.3.5, they work as expected again.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)