Skip to content

grammalecte: 0.5.17 -> 0.5.17.2 #27190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 13, 2017
Merged

grammalecte: 0.5.17 -> 0.5.17.2 #27190

merged 4 commits into from
Jul 13, 2017
+18 −4

Conversation

apeyroux
Copy link
Member

@apeyroux apeyroux commented Jul 6, 2017

Motivation for this change

up to 0.5.17.2

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@apeyroux apeyroux changed the title Up grammalecte 0.5.17 to 0.5.17.2 grammalecte: 0.5.17 -> 0.5.17.2 Jul 6, 2017
@pSub pSub added the 8.has: package (update) This PR updates a package to a newer version label Jul 7, 2017
@apeyroux
Copy link
Member Author

apeyroux commented Jul 7, 2017 •
edited
Loading

I asked the developer of the application not to touch the archives of the releases to avoid breaking the builds. https://www.dicollecte.org/thread.php?prj=fr&t=640

We have agreed that the source archives remain in http://www.dicollecte.org/grammalecte/zip/.

Mic92
Mic92 reviewed Jul 13, 2017
View reviewed changes
pkgs/development/python-modules/grammalecte/spellchecker.patch
# Useful to check several dictionaries at once.

-import ibdawg
+from grammalecte import ibdawg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there reason, why this is not upstream?

@Mic92 Mic92 merged commit 8fa0b47 into NixOS:master Jul 13, 2017
@Mic92
Copy link
Member

Mic92 commented Jul 13, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apeyroux @Mic92 @pSub