Skip to content

qutebrowser: 0.10.1 -> 0.11.0 #27193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2017
Merged

qutebrowser: 0.10.1 -> 0.11.0 #27193

merged 1 commit into from
Jul 9, 2017
+5 −5

Conversation

calvertvl
Copy link
Contributor

Motivation for this change

Version bump.

Note that there is an outstanding semi-issue (first-run splash page) as the standard QTWebKit distribution is being phased out (for Qutebrowser) as it no longer receives security updates. Possible fixes:

  • Just use QTWebEngine, and disable QTWebkit...but apparently QTWebEngine doesn't work very well on Nouveau?
  • QTWebKit-NG is the secondary option, but apparently has not been packaged on NixOS; it is available here
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • (N/A) Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@pSub pSub added the 8.has: package (update) This PR updates a package to a newer version label Jul 7, 2017
@FRidh FRidh requested a review from abbradar July 7, 2017 15:37
@abbradar
Copy link
Member

abbradar commented Jul 9, 2017

Quick heads-up -- I won't be able to work on NixOS (and generally be available online) for two more weeks.

@joachifm joachifm merged commit 316dd74 into NixOS:master Jul 9, 2017
@joachifm
Copy link
Contributor

joachifm commented Jul 9, 2017

@calvertvl Thank you. if you have not already, consider opening a tracking issue for the qtwebkit thing.

@calvertvl calvertvl deleted the upd_qutebrowser-0.11.0 branch July 9, 2017 20:34
@The-Compiler
Copy link
Contributor

Sorry for kind of hijacking this, qutebrowser upstream here 😉

There's actually a discussion open about what support to drop in the next release (v1.0), see qutebrowser/qutebrowser#2742 - would be great if someone can comment on it from NixOS' perspective, also for the other things I'm considering to drop.

And 👍 on packaging the new QtWebKit - others are doing the same (Fedora, Archlinux, soon Debian and Void), and it's a drop-in replacement with some >3 years of security fixes compared to the current one. Should I open an issue, or will @calvertvl do so?

@calvertvl
Copy link
Contributor Author

@The-Compiler @joachifm Opened #27337 for packaging QtWebKit-NG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar

Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@calvertvl @abbradar @joachifm @The-Compiler @pSub