Skip to content

ammonite: disable remote logging by default #26784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

markus1189
Copy link
Contributor

Motivation for this change

Ammonite has introduced user tracking, that is on by default. However you can disable it by passing --no-remote-logging.

This adds this as an argument to the build for ammonite and by default disables remote logging. Users can still opt-in into the tracking by passing disableRemoteLogging = false

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@markus1189, thanks for your PR! By analyzing the history of the files in this pull request, we identified @NeQuissimus to be a potential reviewer.

@Mic92 Mic92 merged commit 69ca7b1 into NixOS:master Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants