Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scyther: init at 1.1.3 #26785

Closed
wants to merge 1 commit into from
Closed

scyther: init at 1.1.3 #26785

wants to merge 1 commit into from

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jun 23, 2017

Motivation for this change

@infinisil was trying to package this. Now it seems to be working.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

@FRidh Ah, so you tried this before? I thought about fixing up some things, including having mutliple versions (including latest master and the compromise-0.9.2 version), being able to build it on Darwin and excluding the gui part.

The reason I put this in a single package is because when people want to install the scyther package, they're gonna want the GUI version, only rarely someone would want only the CLI part. With the option to turn the GUI off this works nicely.

Referring https://github.com/Infinisil/nix-scyther/blob/master/default.nix

@FRidh
Copy link
Member Author

FRidh commented Jun 23, 2017

@infinisil no, I haven't. I just saw your posts in the channel and decided to have a look at it.

I have no idea how one commonly uses this package. Its easy to merge them into a single derivation again.

@infinisil
Copy link
Member

I will continue working on this package for a bit, it's not quite ready yet. I'll make a PR myself when it's done.

@FRidh FRidh closed this Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FRidh @infinisil