git-big-picture: init at 0.9.0 #27206
Conversation
| { fetchgit, python2Packages, stdenv, git, graphviz }: | ||
|
|
||
| python2Packages.buildPythonApplication rec { | ||
| pname = "git-big-picture"; |
There was a problem hiding this comment.
Indeed. Sorry about that.
|
|
||
| name = "${pname}-${version}"; | ||
|
|
||
| src = fetchgit { |
There was a problem hiding this comment.
you're fetching from GitHub, for which we have fetchFromGitHub
| sha256 = "1h283gzs4nx8lrarmr454zza52cilmnbdrqn1n33v3cn1rayl3c9"; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = [ git graphviz ]; |
There was a problem hiding this comment.
You want these to be available during runtime, not propagate them to packages depending on this package.
You'll want to wrap binaries created by this package and put git and graphviz on PATH. Check makeBinPath.
(I think I know why you add them as propagatedBuildInputs because that's what we do with Python packages for run-time dependencies. Its not the same.)
There was a problem hiding this comment.
Learned something new there. Thanks! Does the new update look better?
| homepage = https://github.com/esc/git-big-picture; | ||
| license = stdenv.lib.licenses.gpl3; | ||
| platforms = stdenv.lib.platforms.linux; | ||
| }; |
There was a problem hiding this comment.
will you add yourself as maintainer of this package?
Updated after review comments.
|
Thanks! |
Motivation for this change
To introduce git-big-picture; a Git repository visualization tool. Visualizes branches, commits and tags, using Git and Graphviz.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)