Add ABC verifier library in addition to the executable. #27198
Conversation
|
Thanks! Are there some specific reasons for cloning the package, instead of modifying the existing package to install the library as well? |
| homepage = "https://people.eecs.berkeley.edu/~alanmi/abc/abc.htm"; | ||
| license = stdenv.lib.licenses.mit; | ||
| platforms = stdenv.lib.platforms.unix; | ||
| maintainers = [ stdenv.lib.maintainers.thoughtpolice ]; |
There was a problem hiding this comment.
No, sorry. I'll fix this, thank you for catching it.
|
I did not modify the existing package because it uses the name "abc-verifier", but applications wishing to link against libabc would look for the package by the name "abc". |
| @@ -30,6 +30,6 @@ stdenv.mkDerivation rec { | |||
| homepage = "https://people.eecs.berkeley.edu/~alanmi/abc/abc.htm"; | |||
| license = stdenv.lib.licenses.mit; | |||
| platforms = stdenv.lib.platforms.unix; | |||
| maintainers = [ stdenv.lib.maintainers.thoughtpolice ]; | |||
| maintainers = [ ]; | |||
There was a problem hiding this comment.
Do you want to maintain this package instead?
There was a problem hiding this comment.
I'm not completely sure of the implications or criteria for package maintenance or the qualification process for maintainers, but I'm tentatively willing to under the assumption that it mostly involves keeping the package up to date and responding to nix-build-related issues for the package.
There was a problem hiding this comment.
@kwquick that's about the extent of it, if you're still up for it please consider adding yourself as the maintainer.
|
Replaced by pull request #30566 |
Motivation for this change
The ABC verifier package will build both an executable and a library. This adds the nix specification for building the libabc library for applications needing it.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)