Why?

@ysbaddaden Current codebase fail on bin/crystal doc, see discussion started with #4675 (comment)

➜  crystal git:(master) ✗  LLVM_CONFIG=llvm-config-4.0 bin/crystal doc
Using compiled compiler at `.build/crystal'
Error in line 1: while requiring "./src/**"

in src/crystal/system/unix/arc4random.cr:1: expanding macro

{% skip_file unless flag?(:openbsd) %}
^

in src/crystal/system/unix/arc4random.cr:1: undefined macro variable 'skip_file'

{% skip_file unless flag?(:openbsd) %}
   ^~~~~~~~~

Wouldn't it make more sense to rename everything to skip_file? That's more descriptive of what happens

/cc @mverzilli

Thanks. Always link or copy-paste explanations. We do not necessarily notice buried comments.

Keep skip_file() with forced parens, so it's obvious to the compiler that it's a method call. This macro name is more descriptive than a clueless skip.

skip_file was the original name, then we decided to change it to skip (skip_file only existed for a couple of days in master). I guess in the meantime we merged the code @akzhan is trying to fix now.

I see your point that skip_file is more descriptive than skip, and given it's not going to be a very commonly used feature, more clarity is well worth the extra keystrokes.

So I'd suggest that we closed this PR and opened another one renaming skip to skip_file.

It's time to prefer skip_file.