Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmPackages_4: 4.0.0 -> 4.0.1 #26905

Merged
merged 1 commit into from
Jul 8, 2017
Merged

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 27, 2017

Motivation for this change

Minor update.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Jun 27, 2017

Running nox-review presently :).

@copumpkin
Copy link
Member

Given that this is a mass darwin rebuild, I'd probably send it to staging. Otherwise looks good.

@vcunat
Copy link
Member

vcunat commented Jun 28, 2017

Uh, I see no announcement on ML or mention on llvm.org yet :-) If llvmPackages themselves build OK after this, merging to staging should be a no-brainer. (better have a look at official NEWS as well before merging to master, though)

@dtzWill
Copy link
Member Author

dtzWill commented Jun 28, 2017

Hmm, don't currently have the resources to complete the nox-review myself in a timely manner, sorry :).

And the release is finalized but indeed no official announcement yet.

The release docs are here: http://releases.llvm.org/4.0.1/docs/ReleaseNotes.html
although it doesn't mention anything about what's fixed in the point release (indeed it refers to itself as "4.0.0"), but release management is hard.

As for determining what's changed I think the best to be done is bouncing through the commits on the release branches, for example LLVM 4.0 commits, but we'll see once the release is mentioned on the ML/website :).

@dtzWill
Copy link
Member Author

dtzWill commented Jun 28, 2017

@vcunat If you look through llvm-commits@ (this week's threads, you'll see it's not as premature is it might seem :).

Anyway, hopefully no big deal just need to rebuild all the things 😁

@vcunat
Copy link
Member

vcunat commented Jun 28, 2017

That doc seems just for 3.9.x -> 4.0.0 update. No need to finish nox-review; it would be thousands of packages just on x86_64-linux. Trying to build Darwin stdenv would actually give some confidence bump, but I'll chance a merge if noone volunteers for that soon. (Hydra's rebuilding staging heavily ATM and I'd prefer to wait until the next iteration anyway.)

@LnL7
Copy link
Member

LnL7 commented Jun 28, 2017

I'll do a build of the stdenv and some basic packages.

@FRidh FRidh changed the base branch from master to staging June 28, 2017 21:36
@FRidh FRidh changed the base branch from staging to master June 28, 2017 21:36
@LnL7
Copy link
Member

LnL7 commented Jul 4, 2017

Forgot to report back, everything looks ok on darwin (and nixos).

vcunat added a commit that referenced this pull request Jul 5, 2017
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK.

@vcunat
Copy link
Member

vcunat commented Jul 5, 2017

Staged.

@dtzWill
Copy link
Member Author

dtzWill commented Jul 7, 2017

It's officially mentioned on the website now, haha: http://llvm.org/

Bugged'em after it was pointed out that it didn't /look/ officially released yet 😇. No hard feelings-- it's a volunteer job and I'm sure we can sympathize with how challenging release management can be!

@vcunat
Copy link
Member

vcunat commented Jul 7, 2017

Even the announcement mail was about a week after this PR was submitted...

@LnL7 LnL7 merged commit 495a022 into NixOS:master Jul 8, 2017
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: mass-darwin-rebuild 1.severity: mass-rebuild 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants