-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvmPackages_4: 4.0.0 -> 4.0.1 #26905
Conversation
Running nox-review presently :). |
Given that this is a mass darwin rebuild, I'd probably send it to staging. Otherwise looks good. |
Uh, I see no announcement on ML or mention on llvm.org yet :-) If |
Hmm, don't currently have the resources to complete the nox-review myself in a timely manner, sorry :). And the release is finalized but indeed no official announcement yet. The release docs are here: http://releases.llvm.org/4.0.1/docs/ReleaseNotes.html As for determining what's changed I think the best to be done is bouncing through the commits on the release branches, for example LLVM 4.0 commits, but we'll see once the release is mentioned on the ML/website :). |
@vcunat If you look through llvm-commits@ (this week's threads, you'll see it's not as premature is it might seem :). Anyway, hopefully no big deal just need to rebuild all the things 😁 |
That doc seems just for 3.9.x -> 4.0.0 update. No need to finish nox-review; it would be thousands of packages just on |
I'll do a build of the stdenv and some basic packages. |
Forgot to report back, everything looks ok on darwin (and nixos). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK.
Staged. |
It's officially mentioned on the website now, haha: http://llvm.org/ Bugged'em after it was pointed out that it didn't /look/ officially released yet 😇. No hard feelings-- it's a volunteer job and I'm sure we can sympathize with how challenging release management can be! |
Even the announcement mail was about a week after this PR was submitted... |
Motivation for this change
Minor update.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)