nixos: Force check the filesystem before resizing #26912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message buffer of the kernel lists > Please run 'e2fsck -f /dev/disk/by-label/nixos' first. as the output of the command `resize2fs "$device"`. This fixes NixOS#26910.
0xABAB
reviewed
Jun 28, 2017
| @@ -301,6 +301,7 @@ mountFS() { | |||
| *x-nixos.autoresize*) | |||
| if [ "$fsType" = ext2 -o "$fsType" = ext3 -o "$fsType" = ext4 ]; then | |||
There was a problem hiding this comment.
This can better be written with a case statement.
There was a problem hiding this comment.
This line is not part of this PR, so suggesting improvements to it is kind of off-topic for this PR.
0xABAB
suggested changes
Jun 28, 2017
0xABAB
approved these changes
Jul 2, 2017
knedlsepp
added a commit
to knedlsepp/knedlsepp.at
that referenced
this pull request
Jul 22, 2017
This was needed before the PR NixOS/nixpkgs#26912 was merged to get back a working server with an expanded EBS.
|
I'm going to backport this to 17.03 - 31a956f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This should fix filesystems not being resized on boot (#26910)
I simply added the filesystem check as suggested by the error log of
resize2fs.On the next boot everything was resized automatically.
I'm however not sure what other implications this change might have.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)