Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotify: 1.0.55.487.g256699aa-16 -> 1.0.57.474.gca9c9538-30 #26794

Merged
merged 1 commit into from
Jun 24, 2017
Merged

spotify: 1.0.55.487.g256699aa-16 -> 1.0.57.474.gca9c9538-30 #26794

merged 1 commit into from
Jun 24, 2017
+2 −2

Conversation

hirnpfirsich
Copy link
Contributor

@hirnpfirsich hirnpfirsich commented Jun 23, 2017 •
edited
Loading

Motivation for this change

Updated spotify to the latest version

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Ma27
Copy link
Member

Ma27 commented Jun 24, 2017

just out of interest: we currently have several failing packages due to the removal of the download sources from the providers. Do we have any way to provide the sources/packages on our own or could this cause legal issues?

@Mic92
Copy link
Member

Mic92 commented Jun 24, 2017 •
edited
Loading

Depends on the license of the product. Some licenses allow redistribution. For proprietary we usually backport the latest version instead.

@Mic92 Mic92 merged commit 2c6fbc7 into NixOS:master Jun 24, 2017
Mic92 pushed a commit that referenced this pull request Jun 24, 2017
@hirnpfirsich @Mic92
spotify: 1.0.55.487.g256699aa-16 -> 1.0.57.474.gca9c9538-30 (#26794)
916970f 
(cherry picked from commit 2c6fbc7)
@Mic92 Mic92 mentioned this pull request Jun 24, 2017
Closed
8 tasks
@hirnpfirsich hirnpfirsich deleted the fix/spotify-update branch June 24, 2017 22:20
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
spotify: 1.0.55.487.g256699aa-16 -> 1.0.57.474.gca9c9538-30 (NixOS#26794
fe8e19d 
)

(cherry picked from commit 2c6fbc7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuuzetsu Fuuzetsu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hirnpfirsich @Ma27 @Mic92 @Fuuzetsu