Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fossil: 1.36 -> 2.2 #26796

Merged
merged 1 commit into from
Jul 6, 2017
Merged

fossil: 1.36 -> 2.2 #26796

merged 1 commit into from
Jul 6, 2017

Conversation

lheckemann
Copy link
Member

Motivation for this change

Upstream update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Some of the tests fail — I don't know if the failures are meaningful in the context of nix and they don't seem to cause the test runner to return a bad exit code but hopefully someone who knows more about fossil can work that out before this gets merged?

@mention-bot
Copy link

@lheckemann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @7c6f434c, @viric and @maggesi to be potential reviewers.

Copy link
Contributor

@0xABAB 0xABAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under the condition that fossil 1 repositories can be read by fossil 2. If not, then a new package should be added for fossil 2.

@vbgl vbgl merged commit 3f8f8bf into NixOS:master Jul 6, 2017
@lheckemann lheckemann deleted the fossil branch July 6, 2017 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants