Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old old metadata #2852

Merged
merged 4 commits into from Jun 24, 2017
Merged

Remove old old metadata #2852

merged 4 commits into from Jun 24, 2017

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented Jun 23, 2017

Fix #2839

Kwpolska
Kwpolska approved these changes Jun 23, 2017
View reviewed changes
Copy link
Member

@Kwpolska Kwpolska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nikola/post.py
# a 1-file post.
return get_metadata_from_file(path, config, lang), newstylemeta
else:
if not _UPGRADE_METADATA_ADVERTISED:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That variable can be deleted.

CHANGES.txt Outdated
Deletions
---------

* Removed old 7-line metadata format (Issue #2839)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s Removed features for that, below.

Roberto Alsina and others added 2 commits June 23, 2017 12:04
lint
62b7ff2
@Kwpolska
Remove unused variable
c971342 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska merged commit 8b0f5d4 into master Jun 24, 2017
@Kwpolska Kwpolska deleted the remove-old-old-metadata branch June 24, 2017 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwpolska Kwpolska Kwpolska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ralsina @Kwpolska