Skip to content

beets: 1.4.3 -> 1.4.5 #26959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2017
Merged

beets: 1.4.3 -> 1.4.5 #26959

merged 1 commit into from
Jun 30, 2017
+12 −5

Conversation

jfrankenau
Copy link
Member

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @aszlig @domenkozar @pjones @Profpatsch

Sorry, something went wrong.

@Profpatsch Profpatsch requested a review from aszlig June 29, 2017 11:04
@pjones
Copy link
Contributor

pjones commented Jun 29, 2017

+1

@bennofs
Copy link
Contributor

bennofs commented Jun 30, 2017

Looks good, thanks!

@bennofs bennofs merged commit 65d5515 into NixOS:master Jun 30, 2017
@jfrankenau jfrankenau deleted the beets-1.4.5 branch June 30, 2017 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aszlig aszlig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jfrankenau @pjones @bennofs