Skip to content

Update gambit and gerbil #26947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Update gambit and gerbil #26947

wants to merge 2 commits into from
+131 −22

Conversation

fare
Copy link
Contributor

@fare fare commented Jun 29, 2017

Motivation for this change

Use some recent capabilities of gerbil, that themselves require a recent unreleased gambit.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@fare, thanks for your PR! By analyzing the history of the files in this pull request, we identified @thoughtpolice, @Mic92 and @7c6f434c to be potential reviewers.

0xABAB
0xABAB reviewed Jun 29, 2017
View reviewed changes
pkgs/development/compilers/gambit/default.nix Outdated
(cd boot && ./configure && make bootstrap ) &&
cp -a boot/gsc-boot* ./ &&
make -j2 from-scratch &&
make check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a separate phase for this.

0xABAB
0xABAB suggested changes Jun 29, 2017
View reviewed changes
Copy link
Contributor

@0xABAB 0xABAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put make check in a different phase.

@fare
Copy link
Contributor Author

fare commented Jun 29, 2017

Indeed. I added doCheck = true; instead.

@fare
Copy link
Contributor Author

fare commented Jun 30, 2017

Yet another update, to enable various FFI libraries in gerbil.

0xABAB
0xABAB reviewed Jun 30, 2017
View reviewed changes
pkgs/development/compilers/gerbil/default.nix Outdated
@@ -20,6 +33,7 @@ stdenv.mkDerivation rec {
'';

buildPhase = ''
substituteInPlace "src/std/build-config.ss" --replace '#f)' '#t)'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a comment and seems fragile for updates.

0xABAB
0xABAB approved these changes Jul 1, 2017
View reviewed changes
Copy link
Contributor

@0xABAB 0xABAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, now the code is obvious.

@fare fare force-pushed the master branch 2 times, most recently from a2cf9b2 to 611c25c Compare July 1, 2017 20:43
@fare
Copy link
Contributor Author

fare commented Jul 2, 2017

Ping. What's the next step?

@0xABAB
Copy link
Contributor

0xABAB commented Jul 2, 2017

Some options:

  • You are patient and just wait.
  • You can ping someone who is a 'Member' and not a mere 'Contributor' (like I am) and who has been recently active.
  • You can look on IRC whether you see someone speak with a nickname matching one of the member's nicknames.
  • You can send an e-mail to the mailing list

The strategy I would recommend to you is to use the code you have produced yourself and then just hope that it will be merged and see PRs as a kind of asynchronous system.

This could be handled better, sure.

@fare
Copy link
Contributor Author

fare commented Jul 4, 2017

NB: Meanwhile I'll keep updating those commits, mostly to take advantage of gambit and gerbil updates.

Please make sure to review again before you merge, though it should be mostly version changes and build script tweaks.

fare added 2 commits July 5, 2017 01:37
@fare
gambit: 4.8.6 -> 4.8.8-f3ffeb6
45faf09 
Using a yet unreleased development version of gambit,
so as to be able to build a recent gerbil.

Update the way gambit is bootstrapped, which involves building a
release version of gambit (which for a development gambit, is not the
same version as the current version of gambit).
@fare
gerbil: 0.11 -> 0.12-DEV
9ceff58
@0xABAB
Copy link
Contributor

0xABAB commented Jul 6, 2017

@fare I think you should also use the nativeBuildInputs attribute #19370. See the packaging of mit-scheme as an example. More information here: #1915.

@fare
Copy link
Contributor Author

fare commented Jul 6, 2017

While gambit can be built with a cross-compiler, the current package won't build if you do. Moreover, you'd need to be able to tell that that the dependency on the bootstrap package was a native dependency, not a target dependency.

As for gerbil, I suppose it also could be built with a cross-compiler, but then I might need both a native gambit and a target gambit, and a cross gambit. That's getting complicated.

@0xABAB
Copy link
Contributor

0xABAB commented Jul 7, 2017

@7c6f434c or @Mic92 Please merge this.

@Mic92
Copy link
Member

Mic92 commented Jul 7, 2017

merged both in f96e4ed

@Mic92 Mic92 closed this Jul 7, 2017
@0xABAB
Copy link
Contributor

0xABAB commented Jul 7, 2017

@Mic92 The diff was way bigger. It seems you missed some files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xABAB 0xABAB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fare @mention-bot @0xABAB @Mic92