pythonPackages.py3status: 3.0 -> 3.5 #26965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xABAB
approved these changes
Jun 30, 2017
FRidh
reviewed
Jul 17, 2017
| }; | ||
| propagatedBuildInputs = with self; [ requests ]; | ||
| propagatedBuildInputs = with self; [ requests dbus-python pkgs.file ]; | ||
| doCheck = false; |
|
ping |
|
Sorry for not getting back to you, exams and stuff... I actually disabled tests to make this work on Python 3, but I think I'll need to work on this again to also call the python3 version in all-packages.nix. |
|
Actually, I think I'll open a new pull request when I have the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added some patches to fix binary paths.
pkgs.fileis needed to detect file encoding.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Just to ping the maintainer: @garbas