Skip to content

vaapiIntelG45H264: init at 1.8.2 #26963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jfrankenau
Copy link
Member

Motivation for this change

The vaapiIntel package provides MPEG-2 decoding only for GMA 4500 series GPUs. The experimental g45-h264 branch enables H.264 decoding for those chipsets.

I've based this package upon the original vaapiIntel package as well as the libva-intel-driver-g45-h264 package in the Arch Linux User Repository which includes a patch for Ironlake graphics as well. The latter one is only available as an anonymous gist which is why I've added it here.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@FRidh
Copy link
Member

FRidh commented Jul 27, 2017

Typically we only add stable releases to Nixpkgs. This is an experimental branch and I would think would also be used only by very few. Do you think it is worth adding it to the package set, considering it needs to be maintained (in this case by yourself) as well? Technically, this PR looks good to me.

@jfrankenau
Copy link
Member Author

This package is comparatively popular in the Arch Linux User Repository where the remaining development happens. A stable release will never happen as upstream dropped this branch.

However taking into account that after a month nobody gave a +1, I believe I am the only NixOS user interested in this package. And as the time goes by there will be even less people in possession of such old hardware (a Thinkpad X200 in my case) and thus it is probably best to close this PR. I will keep my fork up to date as long as my laptop is alive and if someone needs it he/she should be able to find this PR and simply add this package manually.

@FRidh, thank you for your time.

@jfrankenau jfrankenau closed this Jul 27, 2017
@FRidh
Copy link
Member

FRidh commented Jul 28, 2017

If someone needs it they should indeed be able to find your code or at least this issue here now. Thanks!

@jfrankenau jfrankenau deleted the vaapiIntelG45H264 branch August 10, 2018 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants