kernel: Refactor after_fork_child_callbacks #4692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
RX14
requested changes
Jul 9, 2017
src/kernel.cr
Outdated
| ->{ Event::SignalHandler.after_fork; nil }, | ||
| ->{ Event::SignalChildHandler.instance.after_fork; nil }, | ||
| ->{ Random::DEFAULT.new_seed; nil }, | ||
| ->{ Scheduler.after_fork }, |
There was a problem hiding this comment.
We should be able to use just ->Scheduler.after_fork syntax here.
There was a problem hiding this comment.
True, it works for most calls, I changed it!
It doesn't work for ->Event::SignalChildHandler.instance.after_fork because there is 2 calls, first instance then after_fork, we can't shorten this one.
bew
force-pushed
the
refactor-kernel-after-fork-callbacks
branch
from
a4ea3b8
to
33fce60
Compare
bew
changed the title
RX14
approved these changes
Jul 9, 2017
mverzilli
approved these changes
Jul 9, 2017
|
Nice catch, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nils were probably needed, when the type inference wasn't powerful enough. They are not necessary anymore.