antigen: init at 2.2.1 #27266
Merged
antigen: init at 2.2.1 #27266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xABAB
approved these changes
Jul 9, 2017
|
I don't sure about that kind of dowloading script, because it will cause old versions be the same as last version, but it's recommended way to install it |
Mic92
reviewed
Jul 9, 2017
pkgs/shells/antigen/default.nix
Outdated
| name = "antigen"; | ||
|
|
||
| src = fetchurl { | ||
| url = "git.io/antigen"; |
There was a problem hiding this comment.
This source is not stable. Is there a different source, which does not break with every upstream update?
There was a problem hiding this comment.
There are releases, I can fetch file from there. Or clone a repo and build it
There was a problem hiding this comment.
Is fetching from https://github.com/zsh-users/antigen/releases/download/v${version}/antigen.zsh will be ok?
There was a problem hiding this comment.
Either from the release page, or using fetchFromGitHub.
|
Thanks. I did not notice the update. |
bkchr
pushed a commit
to bkchr/nixpkgs
that referenced
this pull request
Oct 12, 2017
* Added antigen * Repaced link to releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Want to add antigen. Also I've planned to add module for it, similar to oh-my-zsh
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)