emsciptenStdenv: allow reuse without ./autogen.sh #27250
Merged
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please rebase your patch and i will merge it. looks good, just compiled everything locally. |
The configure phase of emscriptenStdenv exspects an ./autogen.sh script, which is anoying when this step is not needed. Good example is emscriptenPackages.zlib which needs to override configurePhase.
ck3d
force-pushed
the
fix-emscriptenStdenv-autogen
branch
from
2ebdbb1 to
38516ba
Compare
|
Rebase done, thanks! |
GrahamcOfBorg
added
10.rebuild-darwin: 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configure phase of emscriptenStdenv expects an ./autogen.sh script,
which is annoying when this step is not needed. Good example is
emscriptenPackages.zlib which needs to override configurePhase.
Testing
I built all emscriptenPackages (json_c, zlib, libxml2) without regression.
Libxml2 still failes and the rest is building, but the output is not usable.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)