squid service: initial service based on default config #27256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachp
changed the title
0xABAB
reviewed
Jul 10, 2017
| Type="forking"; | ||
| PIDFile="/run/squid.pid"; | ||
| PermissionsStartOnly = true; | ||
| ExecStart = "${pkgs.squid}/bin/squid -YCs -f ${squidConfig}"; |
There was a problem hiding this comment.
I don't think anything needs escaping. All arguments are fixed and the config file path is generated. Do I miss something?
bachp
changed the title
|
I did run this for some time now and it works. So for basic proyxing it is enough to do I think it can be merged. |
|
@bjornfor systemd service description is now starting with capital letter. |
|
@fpletz this is no longer WIP |
fpletz
approved these changes
Sep 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Allow to run squid as a NixOS service.
This is work in progress the configuration is based on the the default configuration to make the service work. Currently only the port can be configured.
I'm planning to allow some more configuration by taking inspiration from NethServer.
This is still work in progress but as I'm new to squid and the config is pretty complex I already share my work in case there is a squid expert around wanting to help out.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)