rsync: build with own zlib again #27495
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rsync has its own patched compress function, and to be able to use the `-z` flag, it needs to use that one. With `-zz` rsync can use an external zlib, but then it can't talk to older rsync versions. More details at https://bugs.mageia.org/show_bug.cgi?id=13669
|
@wmertens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @edolstra and @kampfschlaefer to be potential reviewers. |
fpletz
reviewed
Jul 19, 2017
| @@ -21,7 +21,7 @@ stdenv.mkDerivation rec { | |||
| buildInputs = [libiconv zlib popt] ++ stdenv.lib.optional enableACLs acl; | |||
There was a problem hiding this comment.
I think we should also remove zlib from buildInputs just in case and to avoid confusion.
There was a problem hiding this comment.
actually, that way you can specify -zz :) so let's leave it in…
|
Good catch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rsync has its own patched compress function, and to be able to use the
-zflag, it needs to use that one.With
-zzrsync can use an external zlib, but then it can't talk to older rsync versions.More details at https://bugs.mageia.org/show_bug.cgi?id=13669