Skip to content

plasma5: 5.10.3 -> 5.10.4 #27491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2017
Merged

plasma5: 5.10.3 -> 5.10.4 #27491

merged 1 commit into from
Jul 30, 2017
+169 −169

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Jul 19, 2017 •
edited by ttuegel
Loading

Motivation for this change

Scheduled bugfix release.

Full changelog can be found at https://www.kde.org/announcements/plasma-5.10.3-5.10.4-changelog.php

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@adisbladis
plasma5: 5.10.3 -> 5.10.4

Unverified

The committer email address is not verified.
Learn about vigilant mode
176c15a
@FRidh FRidh requested a review from ttuegel July 19, 2017 09:39
ttuegel
ttuegel approved these changes Jul 19, 2017
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested these changes myself. Looks good!

Let's wait to merge this until after the next staging merge. Everything Qt-related is broken in master at the moment, so if we merge this, it will just be broken too. Because it's not in master, it will only delay the channel update.

@adisbladis
Copy link
Member Author

@ttuegel Sounds good!
I'd preferably like this one #27485 merged at the same time to cause a bit less rebuilds.

@ttuegel
Copy link
Member

ttuegel commented Jul 19, 2017

I'd preferably like this one #27485 merged at the same time to cause a bit less rebuilds.

That is my plan!

@ttuegel ttuegel mentioned this pull request Jul 29, 2017
Merged
8 tasks
ttuegel added a commit to ttuegel/nixpkgs that referenced this pull request Jul 30, 2017
@ttuegel
Merge branch 'feature/kde-applications-17.04.3'

Verified

This commit was signed with the committer’s verified signature.
ttuegel Thomas Tuegel
GPG key ID: 22CBF5249D4B4D59
Verified
Learn about vigilant mode
2b29c89 
Merges NixOS#27491, NixOS#27531, and NixOS#27532.
@ttuegel
Copy link
Member

ttuegel commented Jul 30, 2017

Merged via 2b29c89.

@ttuegel ttuegel closed this Jul 30, 2017
@ttuegel ttuegel merged commit 176c15a into NixOS:master Jul 30, 2017
@globin
Copy link
Member

globin commented Aug 2, 2017

One of these seem to have broken plasma5/sddm tests:
https://hydra.nixos.org/build/57873795
https://hydra.nixos.org/build/57872737

@adisbladis
Copy link
Member Author

adisbladis commented Aug 2, 2017 •
edited
Loading

@globin That breakage is unrelated to the upgrade of plasma, it's a breakage of buildenv.
I have submitted a PR with a fix earlier today: #27859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel

Assignees
No one assigned
Labels
6.topic: qt/kde
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adisbladis @ttuegel @globin @FRidh